SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.9.3
Threshold is medium
Effort is default
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 61 | 42 | 0 | 0 |
Files
org.petify.shelter.controller.AdoptionController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.controller.AdoptionController(AdoptionService) may expose internal representation by storing an externally mutable object into AdoptionController.adoptionService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 22 | Medium |
org.petify.shelter.controller.PetController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.controller.PetController(PetService, AdoptionService, ShelterService, FavoritePetService, PetImageService) may expose internal representation by storing an externally mutable object into PetController.adoptionService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 | Medium |
| new org.petify.shelter.controller.PetController(PetService, AdoptionService, ShelterService, FavoritePetService, PetImageService) may expose internal representation by storing an externally mutable object into PetController.petImageService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 | Medium |
| new org.petify.shelter.controller.PetController(PetService, AdoptionService, ShelterService, FavoritePetService, PetImageService) may expose internal representation by storing an externally mutable object into PetController.petService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 | Medium |
| new org.petify.shelter.controller.PetController(PetService, AdoptionService, ShelterService, FavoritePetService, PetImageService) may expose internal representation by storing an externally mutable object into PetController.shelterService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 43 | Medium |
org.petify.shelter.controller.ShelterController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.controller.ShelterController(ShelterService, PetService, AdoptionService) may expose internal representation by storing an externally mutable object into ShelterController.adoptionService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 | Medium |
| new org.petify.shelter.controller.ShelterController(ShelterService, PetService, AdoptionService) may expose internal representation by storing an externally mutable object into ShelterController.petService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 | Medium |
| new org.petify.shelter.controller.ShelterController(ShelterService, PetService, AdoptionService) may expose internal representation by storing an externally mutable object into ShelterController.shelterService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 41 | Medium |
org.petify.shelter.dto.PetResponseWithImages
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.dto.PetResponseWithImages.images() may expose internal representation by returning PetResponseWithImages.images | MALICIOUS_CODE | EI_EXPOSE_REP | 13 | Medium |
| new org.petify.shelter.dto.PetResponseWithImages(Long, String, PetType, String, Integer, boolean, String, Long, Gender, PetSize, boolean, boolean, boolean, boolean, String, List, Double) may expose internal representation by storing an externally mutable object into PetResponseWithImages.images | MALICIOUS_CODE | EI_EXPOSE_REP2 | 13 | Medium |
org.petify.shelter.dto.SwipeResponse
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.dto.SwipeResponse.pets() may expose internal representation by returning SwipeResponse.pets | MALICIOUS_CODE | EI_EXPOSE_REP | 6 | Medium |
| new org.petify.shelter.dto.SwipeResponse(List, Long) may expose internal representation by storing an externally mutable object into SwipeResponse.pets | MALICIOUS_CODE | EI_EXPOSE_REP2 | 6 | Medium |
org.petify.shelter.mapper.PetMapperImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of pet in org.petify.shelter.mapper.PetMapperImpl.toDtoWithImagesAndDistance(Pet, Double) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 161 | Medium |
org.petify.shelter.model.Adoption
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.model.Adoption.getPet() may expose internal representation by returning Adoption.pet | MALICIOUS_CODE | EI_EXPOSE_REP | 44 | Medium |
| new org.petify.shelter.model.Adoption(Long, String, Pet, AdoptionStatus, String, String, String, String, String, boolean, boolean, boolean, String, LocalDateTime) may expose internal representation by storing an externally mutable object into Adoption.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 27 | Medium |
| new org.petify.shelter.model.Adoption(String, Pet, AdoptionStatus, String, String, String, String, String, boolean, boolean, boolean, String) may expose internal representation by storing an externally mutable object into Adoption.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 85 | Medium |
| org.petify.shelter.model.Adoption.setPet(Pet) may expose internal representation by storing an externally mutable object into Adoption.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
org.petify.shelter.model.FavoritePet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.model.FavoritePet.getPet() may expose internal representation by returning FavoritePet.pet | MALICIOUS_CODE | EI_EXPOSE_REP | 45 | Medium |
| org.petify.shelter.model.FavoritePet.setPet(Pet) may expose internal representation by storing an externally mutable object into FavoritePet.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 26 | Medium |
org.petify.shelter.model.Pet
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.model.Pet.getAdoptions() may expose internal representation by returning Pet.adoptions | MALICIOUS_CODE | EI_EXPOSE_REP | 87 | Medium |
| org.petify.shelter.model.Pet.getFavoritePets() may expose internal representation by returning Pet.favoritePets | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
| org.petify.shelter.model.Pet.getImages() may expose internal representation by returning Pet.images | MALICIOUS_CODE | EI_EXPOSE_REP | 93 | Medium |
| org.petify.shelter.model.Pet.getShelter() may expose internal representation by returning Pet.shelter | MALICIOUS_CODE | EI_EXPOSE_REP | 84 | Medium |
| new org.petify.shelter.model.Pet(Long, String, PetType, String, Integer, Gender, boolean, boolean, boolean, boolean, boolean, String, PetSize, Shelter, List, String, List, List) may expose internal representation by storing an externally mutable object into Pet.adoptions | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
| new org.petify.shelter.model.Pet(Long, String, PetType, String, Integer, Gender, boolean, boolean, boolean, boolean, boolean, String, PetSize, Shelter, List, String, List, List) may expose internal representation by storing an externally mutable object into Pet.favoritePets | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
| new org.petify.shelter.model.Pet(Long, String, PetType, String, Integer, Gender, boolean, boolean, boolean, boolean, boolean, String, PetSize, Shelter, List, String, List, List) may expose internal representation by storing an externally mutable object into Pet.images | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
| new org.petify.shelter.model.Pet(Long, String, PetType, String, Integer, Gender, boolean, boolean, boolean, boolean, boolean, String, PetSize, Shelter, List, String, List, List) may expose internal representation by storing an externally mutable object into Pet.shelter | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
| new org.petify.shelter.model.Pet(Shelter, String, boolean, boolean, boolean, boolean, Gender, Integer, String, PetType, PetSize, String) may expose internal representation by storing an externally mutable object into Pet.shelter | MALICIOUS_CODE | EI_EXPOSE_REP2 | 101 | Medium |
| org.petify.shelter.model.Pet.setAdoptions(List) may expose internal representation by storing an externally mutable object into Pet.adoptions | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
| org.petify.shelter.model.Pet.setFavoritePets(List) may expose internal representation by storing an externally mutable object into Pet.favoritePets | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
| org.petify.shelter.model.Pet.setImages(List) may expose internal representation by storing an externally mutable object into Pet.images | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
| org.petify.shelter.model.Pet.setShelter(Shelter) may expose internal representation by storing an externally mutable object into Pet.shelter | MALICIOUS_CODE | EI_EXPOSE_REP2 | 33 | Medium |
org.petify.shelter.model.PetImage
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.model.PetImage.getPet() may expose internal representation by returning PetImage.pet | MALICIOUS_CODE | EI_EXPOSE_REP | 35 | Medium |
| new org.petify.shelter.model.PetImage(Long, String, Pet) may expose internal representation by storing an externally mutable object into PetImage.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 24 | Medium |
| org.petify.shelter.model.PetImage.setPet(Pet) may expose internal representation by storing an externally mutable object into PetImage.pet | MALICIOUS_CODE | EI_EXPOSE_REP2 | 22 | Medium |
org.petify.shelter.model.Shelter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.petify.shelter.model.Shelter.getPets() may expose internal representation by returning Shelter.pets | MALICIOUS_CODE | EI_EXPOSE_REP | 62 | Medium |
| new org.petify.shelter.model.Shelter(Long, String, String, String, String, Double, Double, String, Boolean, String, List) may expose internal representation by storing an externally mutable object into Shelter.pets | MALICIOUS_CODE | EI_EXPOSE_REP2 | 22 | Medium |
| org.petify.shelter.model.Shelter.setPets(List) may expose internal representation by storing an externally mutable object into Shelter.pets | MALICIOUS_CODE | EI_EXPOSE_REP2 | 25 | Medium |
org.petify.shelter.service.PetImageService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.service.PetImageService(PetImageRepository, PetRepository, PetImageMapper, StorageService) may expose internal representation by storing an externally mutable object into PetImageService.storageService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 21 | Medium |
org.petify.shelter.service.PetService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.service.PetService(PetRepository, ShelterRepository, FavoritePetRepository, PetMapper, StorageService) may expose internal representation by storing an externally mutable object into PetService.storageService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 36 | Medium |
org.petify.shelter.service.ShelterService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.service.ShelterService(ShelterRepository, ShelterMapper, StorageService) may expose internal representation by storing an externally mutable object into ShelterService.storageService | MALICIOUS_CODE | EI_EXPOSE_REP2 | 30 | Medium |
org.petify.shelter.service.StorageService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new org.petify.shelter.service.StorageService(AmazonS3) may expose internal representation by storing an externally mutable object into StorageService.space | MALICIOUS_CODE | EI_EXPOSE_REP2 | 17 | Medium |