SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.9.3

Threshold is medium

Effort is default

Summary

Classes Bugs Errors Missing Classes
48 26 0 0

Files

Class Bugs
org.petify.backend.dto.LoginResponseDTO 4
org.petify.backend.dto.UserResponseDTO 4
org.petify.backend.models.ApplicationUser 8
org.petify.backend.models.OAuth2Provider 3
org.petify.backend.models.UserAchievement 4
org.petify.backend.models.VolunteerApplication 2
org.petify.backend.services.CustomOAuth2UserService 1

org.petify.backend.dto.LoginResponseDTO

Bug Category Details Line Priority
org.petify.backend.dto.LoginResponseDTO.getUser() may expose internal representation by returning LoginResponseDTO.user MALICIOUS_CODE EI_EXPOSE_REP 11 Medium
new org.petify.backend.dto.LoginResponseDTO(ApplicationUser, String) may expose internal representation by storing an externally mutable object into LoginResponseDTO.user MALICIOUS_CODE EI_EXPOSE_REP2 20 Medium
new org.petify.backend.dto.LoginResponseDTO(ApplicationUser, String, String) may expose internal representation by storing an externally mutable object into LoginResponseDTO.user MALICIOUS_CODE EI_EXPOSE_REP2 26 Medium
org.petify.backend.dto.LoginResponseDTO.setUser(ApplicationUser) may expose internal representation by storing an externally mutable object into LoginResponseDTO.user MALICIOUS_CODE EI_EXPOSE_REP2 9 Medium

org.petify.backend.dto.UserResponseDTO

Bug Category Details Line Priority
org.petify.backend.dto.UserResponseDTO.getAchievements() may expose internal representation by returning UserResponseDTO.achievements MALICIOUS_CODE EI_EXPOSE_REP 47 Medium
org.petify.backend.dto.UserResponseDTO.getAuthorities() may expose internal representation by returning UserResponseDTO.authorities MALICIOUS_CODE EI_EXPOSE_REP 44 Medium
org.petify.backend.dto.UserResponseDTO.setAchievements(Set) may expose internal representation by storing an externally mutable object into UserResponseDTO.achievements MALICIOUS_CODE EI_EXPOSE_REP2 18 Medium
org.petify.backend.dto.UserResponseDTO.setAuthorities(Set) may expose internal representation by storing an externally mutable object into UserResponseDTO.authorities MALICIOUS_CODE EI_EXPOSE_REP2 18 Medium

org.petify.backend.models.ApplicationUser

Bug Category Details Line Priority
org.petify.backend.models.ApplicationUser.getAchievements() may expose internal representation by returning ApplicationUser.achievements MALICIOUS_CODE EI_EXPOSE_REP 123 Medium
org.petify.backend.models.ApplicationUser.getAuthorities() may expose internal representation by returning ApplicationUser.authorities MALICIOUS_CODE EI_EXPOSE_REP 203 Medium
org.petify.backend.models.ApplicationUser.getProfileImage() may expose internal representation by returning ApplicationUser.profileImage MALICIOUS_CODE EI_EXPOSE_REP 119 Medium
new org.petify.backend.models.ApplicationUser(Integer, String, String, String, String, LocalDate, String, String, String, Set) may expose internal representation by storing an externally mutable object into ApplicationUser.authorities MALICIOUS_CODE EI_EXPOSE_REP2 198 Medium
org.petify.backend.models.ApplicationUser.setAchievements(Set) may expose internal representation by storing an externally mutable object into ApplicationUser.achievements MALICIOUS_CODE EI_EXPOSE_REP2 35 Medium
org.petify.backend.models.ApplicationUser.setAuthorities(Set) may expose internal representation by storing an externally mutable object into ApplicationUser.authorities MALICIOUS_CODE EI_EXPOSE_REP2 35 Medium
org.petify.backend.models.ApplicationUser.setProfileImage(byte[]) may expose internal representation by storing an externally mutable object into ApplicationUser.profileImage MALICIOUS_CODE EI_EXPOSE_REP2 35 Medium
Class org.petify.backend.models.ApplicationUser defines non-transient non-serializable instance field achievements BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.petify.backend.models.OAuth2Provider

Bug Category Details Line Priority
org.petify.backend.models.OAuth2Provider.getUser() may expose internal representation by returning OAuth2Provider.user MALICIOUS_CODE EI_EXPOSE_REP 36 Medium
new org.petify.backend.models.OAuth2Provider(String, String, ApplicationUser, String, String) may expose internal representation by storing an externally mutable object into OAuth2Provider.user MALICIOUS_CODE EI_EXPOSE_REP2 51 Medium
org.petify.backend.models.OAuth2Provider.setUser(ApplicationUser) may expose internal representation by storing an externally mutable object into OAuth2Provider.user MALICIOUS_CODE EI_EXPOSE_REP2 17 Medium

org.petify.backend.models.UserAchievement

Bug Category Details Line Priority
org.petify.backend.models.UserAchievement.getAchievement() may expose internal representation by returning UserAchievement.achievement MALICIOUS_CODE EI_EXPOSE_REP 34 Medium
org.petify.backend.models.UserAchievement.getUser() may expose internal representation by returning UserAchievement.user MALICIOUS_CODE EI_EXPOSE_REP 30 Medium
org.petify.backend.models.UserAchievement.setAchievement(Achievement) may expose internal representation by storing an externally mutable object into UserAchievement.achievement MALICIOUS_CODE EI_EXPOSE_REP2 21 Medium
org.petify.backend.models.UserAchievement.setUser(ApplicationUser) may expose internal representation by storing an externally mutable object into UserAchievement.user MALICIOUS_CODE EI_EXPOSE_REP2 21 Medium

org.petify.backend.models.VolunteerApplication

Bug Category Details Line Priority
org.petify.backend.models.VolunteerApplication.getUser() may expose internal representation by returning VolunteerApplication.user MALICIOUS_CODE EI_EXPOSE_REP 28 Medium
org.petify.backend.models.VolunteerApplication.setUser(ApplicationUser) may expose internal representation by storing an externally mutable object into VolunteerApplication.user MALICIOUS_CODE EI_EXPOSE_REP2 19 Medium

org.petify.backend.services.CustomOAuth2UserService

Bug Category Details Line Priority
new org.petify.backend.services.CustomOAuth2UserService(UserRepository, RoleRepository, OAuth2ProviderRepository, PasswordEncoder, AchievementService) may expose internal representation by storing an externally mutable object into CustomOAuth2UserService.achievementService MALICIOUS_CODE EI_EXPOSE_REP2 48 Medium